Validates presence of User#name

The 2 reasons are :
- creation of user fail if name is empty : in after_save, it tries to create a
namespace with namespace.name = user.name and namespece validates presence
Namespace#name
- in the web app links to team members are broken with empty User#name because
they are of the form <a href'...'> user.name </a>
This commit is contained in:
Cyril 2012-12-12 17:53:43 +01:00
parent 273c0d2aa3
commit 63d9373aa8
3 changed files with 2 additions and 3 deletions

View file

@ -62,6 +62,7 @@ class User < ActiveRecord::Base
has_many :assigned_issues, class_name: "Issue", foreign_key: :assignee_id, dependent: :destroy
has_many :assigned_merge_requests, class_name: "MergeRequest", foreign_key: :assignee_id, dependent: :destroy
validates :name, presence: true
validates :bio, length: { within: 0..255 }
validates :extern_uid, allow_blank: true, uniqueness: {scope: :provider}
validates :projects_limit, presence: true, numericality: {greater_than_or_equal_to: 0}

View file

@ -75,7 +75,7 @@ POST /users
Parameters:
+ `email` (required) - Email
+ `password` (required) - Password
+ `name` - Name
+ `name` (required) - Name
+ `skype` - Skype ID
+ `linkedin` - Linkedin
+ `twitter` - Twitter account

View file

@ -101,8 +101,6 @@ module Gitlab
key = current_user.keys.find params[:id]
key.delete
end
end
end
end