Persist Merge Request diff. Auto merge request close on push
This commit is contained in:
parent
27e3699814
commit
5a3f23f395
10 changed files with 121 additions and 28 deletions
|
@ -7,6 +7,7 @@ class Event < ActiveRecord::Base
|
|||
Reopened = 4
|
||||
Pushed = 5
|
||||
Commented = 6
|
||||
Merged = 7
|
||||
|
||||
belongs_to :project
|
||||
belongs_to :target, :polymorphic => true
|
||||
|
|
|
@ -1,9 +1,14 @@
|
|||
require File.join(Rails.root, "app/models/commit")
|
||||
|
||||
class MergeRequest < ActiveRecord::Base
|
||||
belongs_to :project
|
||||
belongs_to :author, :class_name => "User"
|
||||
belongs_to :assignee, :class_name => "User"
|
||||
has_many :notes, :as => :noteable, :dependent => :destroy
|
||||
|
||||
serialize :st_commits
|
||||
serialize :st_diffs
|
||||
|
||||
attr_protected :author, :author_id, :project, :project_id
|
||||
attr_accessor :author_id_of_changes
|
||||
|
||||
|
@ -32,7 +37,6 @@ class MergeRequest < ActiveRecord::Base
|
|||
scope :closed, where(:closed => true)
|
||||
scope :assigned, lambda { |u| where(:assignee_id => u.id)}
|
||||
|
||||
|
||||
def validate_branches
|
||||
if target_branch == source_branch
|
||||
errors.add :base, "You can not use same branch for source and target branches"
|
||||
|
@ -44,18 +48,65 @@ class MergeRequest < ActiveRecord::Base
|
|||
end
|
||||
|
||||
def diffs
|
||||
st_diffs || []
|
||||
end
|
||||
|
||||
def reloaded_diffs
|
||||
if open? && unmerged_diffs.any?
|
||||
self.st_diffs = unmerged_diffs
|
||||
save
|
||||
end
|
||||
diffs
|
||||
end
|
||||
|
||||
def unmerged_diffs
|
||||
commits = project.repo.commits_between(target_branch, source_branch).map {|c| Commit.new(c)}
|
||||
diffs = project.repo.diff(commits.first.prev_commit.id, commits.last.id) rescue []
|
||||
end
|
||||
|
||||
def last_commit
|
||||
project.commit(source_branch)
|
||||
commits.first
|
||||
end
|
||||
|
||||
# Return the number of +1 comments (upvotes)
|
||||
def upvotes
|
||||
notes.select(&:upvote?).size
|
||||
end
|
||||
|
||||
def commits
|
||||
st_commits || []
|
||||
end
|
||||
|
||||
def probably_merged?
|
||||
unmerged_commits.empty? &&
|
||||
commits.any? && open?
|
||||
end
|
||||
|
||||
def open?
|
||||
!closed
|
||||
end
|
||||
|
||||
def mark_as_merged!
|
||||
self.merged = true
|
||||
self.closed = true
|
||||
save
|
||||
end
|
||||
|
||||
def reloaded_commits
|
||||
if open? && unmerged_commits.any?
|
||||
self.st_commits = unmerged_commits
|
||||
save
|
||||
end
|
||||
commits
|
||||
end
|
||||
|
||||
def unmerged_commits
|
||||
self.project.repo.
|
||||
commits_between(self.target_branch, self.source_branch).
|
||||
map {|c| Commit.new(c)}.
|
||||
sort_by(&:created_at).
|
||||
reverse
|
||||
end
|
||||
end
|
||||
# == Schema Information
|
||||
#
|
||||
|
|
|
@ -73,6 +73,40 @@ class Project < ActiveRecord::Base
|
|||
)
|
||||
end
|
||||
|
||||
def update_merge_requests(oldrev, newrev, ref, author_key_id)
|
||||
return true unless ref =~ /heads/
|
||||
branch_name = ref.gsub("refs/heads/", "")
|
||||
|
||||
key = Key.find_by_identifier(author_key_id)
|
||||
user = key.user
|
||||
|
||||
c_ids = self.commits_between(oldrev, newrev).map(&:id)
|
||||
|
||||
# update commits & diffs for existing MR
|
||||
mrs = self.merge_requests.opened.where(:source_branch => branch_name).all
|
||||
mrs.each do |merge_request|
|
||||
merge_request.reloaded_commits
|
||||
merge_request.reloaded_diffs
|
||||
end
|
||||
|
||||
# Close merge requests
|
||||
mrs = self.merge_requests.opened.where(:target_branch => branch_name).all
|
||||
mrs.each do |merge_request|
|
||||
next unless merge_request.last_commit
|
||||
# Mark as merged & create event if merged
|
||||
if c_ids.include?(merge_request.last_commit.id)
|
||||
merge_request.mark_as_merged!
|
||||
Event.create(
|
||||
:project => self,
|
||||
:action => Event::Merged,
|
||||
:data => {:merge_request_id => merge_request.id},
|
||||
:author_id => user.id
|
||||
)
|
||||
end
|
||||
end
|
||||
true
|
||||
end
|
||||
|
||||
def execute_web_hooks(oldrev, newrev, ref, author_key_id)
|
||||
ref_parts = ref.split('/')
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue