deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

API: return status code 400 if filepath of raw file blob not given

Browse source
This commit is contained in:
Sebastian Ziebell 2013-02-13 14:47:59 +01:00
parent fd01f3aacd
commit 54ab9bb6df
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/api/projects.rb
View file

@ -451,6 +451,8 @@ module Gitlab
get ":id/repository/commits/:sha/blob" do get ":id/repository/commits/:sha/blob" do
authorize! :download_code, user_project authorize! :download_code, user_project
error!("Filepath must be specified", 400) if !params.has_key? :filepath
ref = params[:sha] ref = params[:sha]
commit = user_project.repository.commit ref commit = user_project.repository.commit ref

7
spec/requests/api/projects_spec.rb
View file

@ -468,7 +468,7 @@ describe Gitlab::API do
end end
end end
describe "GET /projects/:id/:sha/blob" do describe "GET /projects/:id/repository/commits/:sha/blob" do
it "should get the raw file contents" do it "should get the raw file contents" do
get api("/projects/#{project.id}/repository/commits/master/blob?filepath=README.md", user) get api("/projects/#{project.id}/repository/commits/master/blob?filepath=README.md", user)
response.status.should == 200 response.status.should == 200
@ -483,5 +483,10 @@ describe Gitlab::API do
get api("/projects/#{project.id}/repository/commits/master/blob?filepath=README.invalid", user) get api("/projects/#{project.id}/repository/commits/master/blob?filepath=README.invalid", user)
response.status.should == 404 response.status.should == 404
end end
it "should return a 400 error if filepath is missing" do
get api("/projects/#{project.id}/repository/commits/master/blob", user)
response.status.should == 400
end
end end
end end