deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

API attributes refactored

Browse source
This commit is contained in:
Alex Denisov 2012-09-16 19:51:04 +03:00
parent caef9ed112
commit 549c4c2202
4 changed files with 36 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/api/milestones.rb
View file

@ -36,12 +36,8 @@ module Gitlab
# Example Request:
# POST /projects/:id/milestones
post ":id/milestones" do
@milestone = user_project.milestones.new(
title: params[:title],
description: params[:description],
due_date: params[:due_date]
)
attrs = existed_attributes [:title, :description, :due_date]
@milestone = user_project.milestones.new attrs
if @milestone.save
present @milestone, with: Entities::Milestone
else
@ -64,14 +60,8 @@ module Gitlab
authorize! :admin_milestone, user_project
@milestone = user_project.milestones.find(params[:milestone_id])
parameters = {
title: (params[:title] || @milestone.title),
description: (params[:description] || @milestone.description),
due_date: (params[:due_date] || @milestone.due_date),
closed: (params[:closed] || @milestone.closed)
}
if @milestone.update_attributes(parameters)
attrs = existed_attributes [:title, :description, :due_date, :closed]
if @milestone.update_attributes attrs
present @milestone, with: Entities::Milestone
else
not_found!