deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Duplicate code removed from IssueObserver#after_update

Browse source
This commit is contained in:
Alex Denisov 2012-08-29 10:50:35 +03:00
parent 2cb0a62f7d
commit 43cad71f1a
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
app/observers/issue_observer.rb
View file

@ -10,17 +10,13 @@ class IssueObserver < ActiveRecord::Observer
def after_update(issue) def after_update(issue)
send_reassigned_email(issue) if issue.is_being_reassigned? send_reassigned_email(issue) if issue.is_being_reassigned?
if issue.is_being_closed? status = nil
Note.create_status_change_note(issue, current_user, 'closed') status = 'closed' if issue.is_being_closed?
status = 'reopened' if issue.is_being_reopened?
if status
Note.create_status_change_note(issue, current_user, status)
[issue.author, issue.assignee].compact.each do |recipient| [issue.author, issue.assignee].compact.each do |recipient|
Notify.issue_status_changed_email(recipient.id, issue.id, 'closed', current_user) Notify.issue_status_changed_email(recipient.id, issue.id, status, current_user)
end
end
if issue.is_being_reopened?
Note.create_status_change_note(issue, current_user, 'reopened')
[issue.author, issue.assignee].compact.each do |recipient|
Notify.issue_status_changed_email(recipient.id, issue.id, 'reopened', current_user)
end end
end end
end end