deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Adds DB-sensitive tablename escape for backup task.

Browse source 
Uses ActiveRecord::Base.connection.quote_table_name.
Fixes issue 2437.
This commit is contained in:
Chris Lawlor 2013-03-14 11:40:09 -04:00
parent d2b882fae5
commit 3df5253cc3
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/tasks/gitlab/backup.rake
View file

@ -178,8 +178,9 @@ namespace :gitlab do
ActiveRecord::Base.connection.tables.each do |tbl| ActiveRecord::Base.connection.tables.each do |tbl|
print " * #{tbl.yellow} ... " print " * #{tbl.yellow} ... "
count = 1 count = 1
safe_tablename = ActiveRecord::Base.connection.quote_table_name(tbl)
File.open(File.join(backup_path_db, tbl + ".yml"), "w+") do |file| File.open(File.join(backup_path_db, tbl + ".yml"), "w+") do |file|
ActiveRecord::Base.connection.select_all("SELECT * FROM `#{tbl}`").each do |line| ActiveRecord::Base.connection.select_all("SELECT * FROM #{safe_tablename}").each do |line|
line.delete_if{|k,v| v.blank?} line.delete_if{|k,v| v.blank?}
output = {tbl + '_' + count.to_s => line} output = {tbl + '_' + count.to_s => line}
file << output.to_yaml.gsub(/^---\n/,'') + "\n" file << output.to_yaml.gsub(/^---\n/,'') + "\n"