Only owner of current namespace can change project namespace

This commit is contained in:
Dmitriy Zaporozhets 2012-12-04 22:06:55 +02:00
parent f6bfa095bf
commit 2a1c5cdf99
3 changed files with 15 additions and 9 deletions

View file

@ -2,7 +2,7 @@ class ProjectUpdateContext < BaseContext
def execute(role = :default) def execute(role = :default)
namespace_id = params[:project].delete(:namespace_id) namespace_id = params[:project].delete(:namespace_id)
if namespace_id.present? if can?(current_user, :change_namespace, project) && namespace_id.present?
if namespace_id == Namespace.global_id if namespace_id == Namespace.global_id
if project.namespace.present? if project.namespace.present?
# Transfer to global namespace from anyone # Transfer to global namespace from anyone

View file

@ -17,9 +17,7 @@ class Ability
# Rules based on role in project # Rules based on role in project
if project.master_access_for?(user) if project.master_access_for?(user)
# TODO: replace with master rules. rules << project_master_rules
# Only allow project administration for namespace owners
rules << project_admin_rules
elsif project.dev_access_for?(user) elsif project.dev_access_for?(user)
rules << project_dev_rules rules << project_dev_rules
@ -93,13 +91,15 @@ class Ability
:admin_merge_request, :admin_merge_request,
:admin_note, :admin_note,
:accept_mr, :accept_mr,
:admin_wiki :admin_wiki,
:admin_project
] ]
end end
def project_admin_rules def project_admin_rules
project_master_rules + [ project_master_rules + [
:admin_project :change_namespace,
:rename_project
] ]
end end

View file

@ -21,9 +21,15 @@
= f.label :namespace_id do = f.label :namespace_id do
%span Namespace %span Namespace
.controls .controls
= f.select :namespace_id, namespaces_options(@project.namespace_id), {prompt: 'Choose a project namespace'}, {class: 'chosen'} - if can? current_user, :change_namespace, @project
&nbsp; = f.select :namespace_id, namespaces_options(@project.namespace_id), {prompt: 'Choose a project namespace'}, {class: 'chosen'}
%span.cred Be careful. Changing project namespace can have unintended side effects &nbsp;
%span.cred Be careful. Changing project namespace can have unintended side effects
- else
%a.btn.btn-small.disabled= @project.namespace.try(:human_name) || "/"
&nbsp;
%span.cred Only owner can change project namespace.
- unless @project.heads.empty? - unless @project.heads.empty?
.clearfix .clearfix