Real fix for removing keys. Closes PR #1616

2012-10-03 15:56:41 +03:00 · 2012-10-03 15:56:41 +03:00 · 2985697af7
parent 9e80d2d4f7
commit 2985697af7
1 changed files with 3 additions and 2 deletions
--- a/lib/gitlab/backend/gitolite_config.rb
+++ b/lib/gitlab/backend/gitolite_config.rb
@ -96,8 +96,9 @@ module Gitlab
    end

    def rm_key(user)
-      File.unlink(File.join(config_tmp_dir, 'gitolite/keydir',"#{user}.pub"))
-      `cd #{File.join(config_tmp_dir,'gitolite')} ; git rm keydir/#{user}.pub`
+      key_path = File.join(config_tmp_dir, 'gitolite/keydir', "#{user}.pub")
+      ga_key = ::Gitolite::SSHKey.from_file(key_path)
+      ga_repo.rm_key(ga_key)
    end

    # update or create