Fixed comments for snippets. Tests fixed

This commit is contained in:
Dmitriy Zaporozhets 2012-02-24 22:36:44 +02:00
parent d41d8ffb02
commit 292a41cbe2
7 changed files with 26 additions and 24 deletions

View file

@ -13,6 +13,8 @@ class NotesController < ApplicationController
@notes = case params[:target_type]
when "commit"
then project.commit_notes(project.commit((params[:target_id]))).fresh.limit(20)
when "snippet"
then project.snippets.find(params[:target_id]).notes
when "wall"
then project.common_notes.order("created_at DESC").fresh.limit(20)
when "issue"

View file

@ -55,7 +55,6 @@ class SnippetsController < ApplicationController
end
def show
@notes = @snippet.notes
@note = @project.notes.new(:noteable => @snippet)
render_full_content
end

View file

@ -0,0 +1,9 @@
- if note.valid?
:plain
$("#new_note .errors").remove();
$('#new_note textarea').val("");
NoteList.prepend(#{note.id}, "#{escape_javascript(render :partial => "notes/show", :locals => {:note => note})}");
- else
:plain
$("#new_note").replaceWith("#{escape_javascript(render('form'))}");

View file

@ -0,0 +1,8 @@
- if note.valid?
:plain
$(".per_line_form").hide();
$('#new_note textarea').val("");
$("a.line_note_reply_link[line_code='#{note.line_code}']").closest("tr").remove();
var trEl = $(".#{note.line_code}").parent();
trEl.after("#{escape_javascript(render :partial => "notes/per_line_show", :locals => {:note => note})}");
trEl.after("#{escape_javascript(render :partial => "notes/reply_button", :locals => {:line_code => note.line_code})}");

View file

@ -1,21 +1,8 @@
- if @note.valid?
- if @note.line_code
:plain
$(".per_line_form").hide();
$('#new_note textarea').val("");
$("a.line_note_reply_link[line_code='#{@note.line_code}']").closest("tr").remove();
var trEl = $(".#{@note.line_code}").parent();
trEl.after("#{escape_javascript(render :partial => "notes/per_line_show", :locals => {:note => @note})}");
trEl.after("#{escape_javascript(render :partial => "notes/reply_button", :locals => {:line_code => @note.line_code})}");
- else
:plain
$("#new_note .errors").remove();
$('#new_note textarea').val("");
NoteList.prepend(#{@note.id}, "#{escape_javascript(render :partial => "notes/show", :locals => {:note => @note})}");
- else
- unless @note.line_code
:plain
$("#new_note").replaceWith("#{escape_javascript(render('form'))}");
- if @note.line_code
= render "create_line", :note => @note
- else
= render "create_common", :note => @note
-# Enable submit button
:plain
$("#submit_note").removeAttr("disabled");

View file

@ -14,8 +14,5 @@
.data.no-padding
:erb
<%= raw @snippet.colorize %>
.clear
%br
.snippet_notes= render "notes/notes"
.clear
= render "notes/notes", :tid => @snippet.id, :tt => "snippet"

View file

@ -8,7 +8,7 @@ describe "Projects", "Wall" do
project.add_access(@user, :read, :write)
end
describe "View notes on wall" do
describe "View notes on wall", :js => true do
before do
Factory :note, :project => project, :note => "Project specs", :author => @user
visit wall_project_path(project)