diff --git a/app/assets/javascripts/wall.js.coffee b/app/assets/javascripts/wall.js.coffee
index a35c8c60..e2fca3dd 100644
--- a/app/assets/javascripts/wall.js.coffee
+++ b/app/assets/javascripts/wall.js.coffee
@@ -58,14 +58,26 @@
form.show()
renderNote: (note) ->
- author = '' + note.author.name + ''
- body = '' + linkify(sanitize(note.body)) + ''
- file = ''
- time = '' + note.created_at + ''
+ template = Wall.noteTemplate()
+ template = template.replace('{{author_name}}', note.author.name)
+ template = template.replace('{{created_at}}', note.created_at)
+ template = template.replace('{{text}}', linkify(sanitize(note.body)))
if note.attachment
- file = '' + note.attachment + ''
-
- html = '' + author + body + file + time + ''
+ file = '' + note.attachment + ''
+ else
+ file = ''
+ template = template.replace('{{file}}', file)
- $('ul.notes').append(html)
+
+ $('ul.notes').append(template)
+
+ noteTemplate: ->
+ return '
+ {{author_name}}
+
+ {{text}}
+ {{file}}
+
+ {{created_at}}
+ '
diff --git a/app/assets/stylesheets/sections/wall.scss b/app/assets/stylesheets/sections/wall.scss
index 598d9df8..8d3b4734 100644
--- a/app/assets/stylesheets/sections/wall.scss
+++ b/app/assets/stylesheets/sections/wall.scss
@@ -14,12 +14,28 @@
.notes {
margin-bottom: 160px;
+ background: #FFE;
+ border: 1px solid #EED;
+
+ > li {
+ @extend .clearfix;
+ border-bottom: 1px solid #EED;
+ padding: 10px;
+ }
.wall-author {
color: #666;
- margin-right: 10px;
- border-right: 1px solid #CCC;
- padding-right: 5px
+ float: left;
+ width: 100px;
+ text-overflow: ellipsis;
+ }
+
+ .wall-text {
+ border-left: 1px solid #CCC;
+ margin-left: 10px;
+ padding-left: 10px;
+ float: left;
+ width: 80%;
}
.wall-file {
diff --git a/app/views/walls/show.html.haml b/app/views/walls/show.html.haml
index 78693b99..139e66f5 100644
--- a/app/views/walls/show.html.haml
+++ b/app/views/walls/show.html.haml
@@ -1,5 +1,5 @@
%div.wall-page
- %ul.well-list.notes
+ %ul.notes
- if can? current_user, :write_note, @project
.note-form-holder
diff --git a/spec/features/notes_on_merge_requests_spec.rb b/spec/features/notes_on_merge_requests_spec.rb
index 670762e8..d48dffc0 100644
--- a/spec/features/notes_on_merge_requests_spec.rb
+++ b/spec/features/notes_on_merge_requests_spec.rb
@@ -21,11 +21,6 @@ describe "On a merge request", js: true do
it { find(".js-main-target-form input[type=submit]").value.should == "Add Comment" }
it { within(".js-main-target-form") { should_not have_link("Cancel") } }
- # notifiactions
- it { within(".js-main-target-form") { should have_unchecked_field("Notify team via email") } }
- it { within(".js-main-target-form") { should_not have_checked_field("Notify commit author") } }
- it { within(".js-main-target-form") { should_not have_unchecked_field("Notify commit author") } }
-
describe "without text" do
it { within(".js-main-target-form") { should have_css(".js-note-preview-button", visible: false) } }
end
@@ -126,9 +121,6 @@ describe "On a merge request diff", js: true, focus: true do
it { should have_button("Add Comment") }
it { should have_css(".js-close-discussion-note-form", text: "Cancel") }
- # notification options
- it { should have_unchecked_field("Notify team via email") }
-
it "shouldn't add a second form for same row" do
find("#4735dfc552ad7bf15ca468adc3cad9d05b624490_185_185.line_holder .js-add-diff-note-button").trigger("click")