From fed1c9804744fa20bfda47d269a4b0b566754ba3 Mon Sep 17 00:00:00 2001 From: Andrey Vakarev Date: Sun, 20 May 2012 03:01:13 +0300 Subject: [PATCH] Refactoring: get rid of ruby antipattern unless/else and use if/else instead --- app/controllers/application_controller.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 17bcef4b..8dd407ac 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -97,12 +97,12 @@ class ApplicationController < ActionController::Base end def load_refs - unless params[:ref].blank? - @ref = params[:ref] - else + if params[:ref].blank? @branch = params[:branch].blank? ? nil : params[:branch] @tag = params[:tag].blank? ? nil : params[:tag] @ref = @branch || @tag || @project.try(:default_branch) || Repository.default_ref + else + @ref = params[:ref] end end