commit.short_id as model method. Styled inline comment form

This commit is contained in:
randx 2012-07-27 11:22:05 +03:00
parent 67ef96ea5f
commit 0590aa9d60
7 changed files with 46 additions and 23 deletions

View file

@ -33,7 +33,7 @@ init:
}) })
$("#note_note").live("focus", function(){ $("#note_note").live("focus", function(){
$(this).css("height", "100px"); $(this).css("height", "80px");
$('.note_advanced_opts').show(); $('.note_advanced_opts').show();
}); });

View file

@ -24,8 +24,8 @@
/* Note textare */ /* Note textare */
#note_note { #note_note {
height:100px; height:80px;
width:97%; width:99%;
font-size:14px; font-size:14px;
} }
@ -100,8 +100,25 @@ tr.line_notes_row {
td { td {
border-bottom:1px solid #ddd; border-bottom:1px solid #ddd;
} }
.actions { .note_actions {
margin:0; margin:0;
padding-top: 10px;
.buttons {
float:left;
width:300px;
}
.options {
.labels {
float:left;
padding-left:10px;
label {
padding: 6px 0;
margin: 0;
width:120px;
}
}
}
} }
} }

View file

@ -1,10 +1,6 @@
class CommitDecorator < ApplicationDecorator class CommitDecorator < ApplicationDecorator
decorates :commit decorates :commit
def short_id(length = 10)
id.to_s[0..length]
end
# Returns the commits title. # Returns the commits title.
# #
# Usually, the commit title is the first line of the commit message. # Usually, the commit title is the first line of the commit message.

View file

@ -114,6 +114,10 @@ class Commit
@head = head @head = head
end end
def short_id(length = 10)
id.to_s[0..length]
end
def safe_message def safe_message
utf8 message utf8 message
end end
@ -150,4 +154,8 @@ class Commit
def prev_commit_id def prev_commit_id
prev_commit.try :id prev_commit.try :id
end end
def parents_count
parents && parents.count || 0
end
end end

View file

@ -1,4 +1,4 @@
.commit-box{class: @commit.parents.count > 1 ? "merge-commit" : ""} .commit-box{class: @commit.parents_count > 1 ? "merge-commit" : ""}
.commit-head .commit-head
.right .right
- if @notes_count > 0 - if @notes_count > 0

View file

@ -1,5 +1,5 @@
= form_for [@project, @note], :remote => "true", :multipart => true do |f| = form_for [@project, @note], :remote => "true", :multipart => true do |f|
%h3 Leave a comment %h3.page_title Leave a comment
-if @note.errors.any? -if @note.errors.any?
.alert-message.block-message.error .alert-message.block-message.error
- @note.errors.full_messages.each do |msg| - @note.errors.full_messages.each do |msg|

View file

@ -2,7 +2,7 @@
%tr.per_line_form %tr.per_line_form
%td{:colspan => 3 } %td{:colspan => 3 }
= form_for [@project, @note], :remote => "true", :multipart => true do |f| = form_for [@project, @note], :remote => "true", :multipart => true do |f|
%h3 Leave a note %h3.page_title Leave a note
%div.span10 %div.span10
-if @note.errors.any? -if @note.errors.any?
.alert-message.block-message.error .alert-message.block-message.error
@ -13,8 +13,13 @@
= f.hidden_field :noteable_type = f.hidden_field :noteable_type
= f.hidden_field :line_code = f.hidden_field :line_code
= f.text_area :note, :size => 255 = f.text_area :note, :size => 255
%h5 Notify via email: .note_actions
.clearfix .buttons
= f.submit 'Add note', :class => "btn primary submit_note", :id => "submit_note"
= link_to "Cancel", "#", :class => "btn hide-button"
.options
%h6.left Notify via email:
.labels
= label_tag :notify do = label_tag :notify do
= check_box_tag :notify, 1, @note.noteable_type != "Commit" = check_box_tag :notify, 1, @note.noteable_type != "Commit"
%span Project team %span Project team
@ -23,9 +28,6 @@
= label_tag :notify_author do = label_tag :notify_author do
= check_box_tag :notify_author, 1 , @note.noteable_type == "Commit" = check_box_tag :notify_author, 1 , @note.noteable_type == "Commit"
%span Commit author %span Commit author
.actions
= f.submit 'Add note', :class => "btn primary submit_note", :id => "submit_note"
= link_to "Close", "#", :class => "btn hide-button"
:javascript :javascript
$(function(){ $(function(){