deac/gitlabhq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #2440 from klamontagne/master

Browse source 
Don't setuid the repositories on installation
This commit is contained in:
Riyad Preukschas 2013-02-01 20:56:03 +01:00
parent 0965aeb2ea f4175219fb
commit 003c312104
3 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
doc/install/installation.md
View file

@ -145,8 +145,9 @@ Fix the directory permissions for the configuration directory:
Fix the directory permissions for the repositories:
# Make sure the repositories dir is owned by git and it stays that way
sudo chmod -R ug+rwXs,o-rwx /home/git/repositories/
sudo chmod -R ug+rwX,o-rwx /home/git/repositories/
sudo chown -R git:git /home/git/repositories/
find /home/git/repositories -type d -print0 | sudo xargs -0 chmod g+s
## Add domains to list to the list of known hosts

2
doc/raketasks/maintenance.md
View file

@ -81,7 +81,7 @@ Config directory owned by git:git? ... yes
Config directory access is drwxr-x---? ... yes
Repo base directory exists? ... yes
Repo base owned by git:git? ... yes
Repo base access is drwsrws---? ... yes
Repo base access is drwxrws---? ... yes
Can clone gitolite-admin? ... yes
Can commit to gitolite-admin? ... yes
post-receive hook exists? ... yes

8
lib/tasks/gitlab/check.rake
View file

@ -716,7 +716,7 @@ namespace :gitlab do
end
def check_repo_base_permissions
print "Repo base access is drwsrws---? ... "
print "Repo base access is drwxrws---? ... "
repo_base_path = Gitlab.config.gitolite.repos_path
unless File.exists?(repo_base_path)
@ -724,12 +724,14 @@ namespace :gitlab do
return
end
if File.stat(repo_base_path).mode.to_s(8).ends_with?("6770")
if File.stat(repo_base_path).mode.to_s(8).ends_with?("2770")
puts "yes".green
else
puts "no".red
try_fixing_it(
"sudo chmod -R ug+rwXs,o-rwx #{repo_base_path}"
"sudo chmod -R ug+rwX,o-rwx #{repo_base_path}",
"sudo chmod -R u-s #{repo_base_path}",
"find #{repo_base_path} -type d -print0 | sudo xargs -0 chmod g+s"
)
for_more_information(
see_installation_guide_section "Gitolite"