deac/couchrest_model
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Save on Document & ExtendedDocument crashed if bulk

Browse source 
- document#save expects to receive {"ok" => true} even with bulk mode
- ExtendedDocument#save_without_callbacks reverted to previous code
  (expecting result["ok"] as in create_without_callbacks)
This commit is contained in:
Julien Sanchez 2009-10-12 19:55:02 +08:00 committed by Matt Aimonetti
parent 1c43a8f3d3
commit b5d6baaf11
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/couchrest/core/database.rb
View file

@ -145,7 +145,7 @@ module CouchRest
end end
if bulk if bulk
@bulk_save_cache << doc @bulk_save_cache << doc
return bulk_save if @bulk_save_cache.length >= @bulk_save_cache_limit bulk_save if @bulk_save_cache.length >= @bulk_save_cache_limit
return {"ok" => true} # Compatibility with Document#save return {"ok" => true} # Compatibility with Document#save
elsif !bulk && @bulk_save_cache.length > 0 elsif !bulk && @bulk_save_cache.length > 0
bulk_save bulk_save

2
lib/couchrest/more/extended_document.rb
View file

@ -238,7 +238,7 @@ module CouchRest
set_unique_id if new? && self.respond_to?(:set_unique_id) set_unique_id if new? && self.respond_to?(:set_unique_id)
result = database.save_doc(self, bulk) result = database.save_doc(self, bulk)
mark_as_saved mark_as_saved
true result["ok"] == true
end end
# Saves the document to the db using save. Raises an exception # Saves the document to the db using save. Raises an exception