Importing an empty array of objects/values should be supported
This commit is contained in:
parent
2517770a38
commit
d901a7c60f
|
@ -178,6 +178,9 @@ class ActiveRecord::Base
|
||||||
end
|
end
|
||||||
# end
|
# end
|
||||||
end
|
end
|
||||||
|
# supports empty array
|
||||||
|
elsif args.last.is_a?( Array ) and args.last.empty?
|
||||||
|
return ActiveRecord::Import::Result.new([], 0) if args.last.empty?
|
||||||
# supports 2-element array and array
|
# supports 2-element array and array
|
||||||
elsif args.size == 2 and args.first.is_a?( Array ) and args.last.is_a?( Array )
|
elsif args.size == 2 and args.first.is_a?( Array ) and args.last.is_a?( Array )
|
||||||
column_names, array_of_attributes = args
|
column_names, array_of_attributes = args
|
||||||
|
|
|
@ -12,6 +12,13 @@ describe "#import" do
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it "should not produce an error when importing empty arrays" do
|
||||||
|
assert_nothing_raised do
|
||||||
|
Topic.import []
|
||||||
|
Topic.import %w(title author_name), []
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
context "with :validation option" do
|
context "with :validation option" do
|
||||||
let(:columns) { %w(title author_name) }
|
let(:columns) { %w(title author_name) }
|
||||||
let(:valid_values) { [[ "LDAP", "Jerry Carter"], ["Rails Recipes", "Chad Fowler"]] }
|
let(:valid_values) { [[ "LDAP", "Jerry Carter"], ["Rails Recipes", "Chad Fowler"]] }
|
||||||
|
|
Loading…
Reference in a new issue