deac/activerecord-import
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Do not use ActiveRecord::Base.new(hsh) when instantiating AR models. Use form of instantiation that allows protected attributes to be set.

Browse source
This commit is contained in:
Zach Dennis 2011-04-29 00:13:26 -04:00
parent 71184b2903
commit 5aefbb2989
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/activerecord-import/import.rb
View file

@ -245,7 +245,9 @@ class ActiveRecord::Base
# keep track of the instance and the position it is currently at. if this fails # keep track of the instance and the position it is currently at. if this fails
# validation we'll use the index to remove it from the array_of_attributes # validation we'll use the index to remove it from the array_of_attributes
arr.each_with_index do |hsh,i| arr.each_with_index do |hsh,i|
instance = new( hsh ) instance = new do |model|
hsh.each_pair{ |k,v| model.send("#{k}=", v) }
end
if not instance.valid? if not instance.valid?
array_of_attributes[ i ] = nil array_of_attributes[ i ] = nil
failed_instances << instance failed_instances << instance